C++ ifstream pointer question - Tilted Forum Project Discussion Community

Prince · 12-11-2003, 06:02 AM

Here's the code, i just want to count the lines of a file. I get a bunch of "invalid simple type name destructor" errors..
It makes a pointer to an input stream to the file specified by the command line parameter. Then it passes the pointer to countlines() to try to count the lines. anyone know why it doesn't work?

Quote:

#include <fstream.h>

#define NULL 0
#define WIDTH 257

int countlines(ifstream *in);

int main(int numArgs, char *args[])
{
if (numArgs != 2)
{
cout << "Usage:\n reader filename.ext";
return 1;
}
ifstream *fin;
fin = new ifstream(args[1], ios::in | ios::nocreate);
cout << countlines(fin);
//char buf[WIDTH];

//for(int i=0; !*fin.eof(); i++)
//{
// *fin.getline(buf, WIDTH);
// cout << buf << "\n";
//}
//
*fin.close();
return 0;
}

int countlines(ifstream *in)
{
int lines = 0;
char null[WIDTH];
while (!*in.eof())
{
*in.getline(null, WIDTH);
lines++;
}
*in.seekg(0, ios::beg);
delete null;
return lines;
}

Prince · 12-11-2003, 06:03 AM

Well, vB removes some small parts of the code apparently in its battle against html tags, but I hope that is understandable anyway.

Pragma · 12-11-2003, 08:06 AM

Quote:

#include iostream
#include fstream
using namespace std;

static const int width = 257;

int countlines(ifstream &in);

int main(int numArgs, char *args[]) {
if (numArgs != 2) {
cout << "Usage:\n reader filename.ext";
return 1;
}
ifstream fin(args[1]);
cout << countlines(fin);

fin.close();
return 0;
}

int countlines(ifstream &in) {
int lines = 0;
char null[width];
while (!in.eof()){
in.getline(null, width);
lines++;
}
in.seekg(0, ios::beg);

return lines;
}

Pragma · 12-11-2003, 08:11 AM

Well, you can't do "delete null;", as it's not dynamic memory.

Other than that, why are you using an ifstream pointer instead of just an ifstream object?

Furthermore, C++ really doesn't like it when you redefine constants for it - such as NULL.

Prince · 12-11-2003, 08:27 AM

You're a genius. Thanks!

cheerios · 12-11-2003, 12:12 PM

for future reference code tags (use em just like quote ones) are great

charliex · 12-11-2003, 08:32 PM

its ok to redefine #define constants, you can even use #undef if you want too first.

NULL is compiler specific, so sometimes you want to override it because the compiler maker goofed it up , say using (void*)0 instead of 0 or 0L

Pragma · 12-12-2003, 06:00 AM

True, you can redefine constants, but most compilers will give you warnings, if not errors, if you don't #undef before you #define.

Either way, I've seen very few cases (and this not being one of them) were actually redefining NULL is warranted.

charliex · 12-12-2003, 05:57 PM

You should never get an error redefining a #define, a typedef yes, if you do the compilers broken.

some compilers will generate an error using #undef on something that was never #define'd so you should always guard it.

Unfortunately theres no easy way of telling the difference between a typedef and a #define.

You might get an error on the use of the redefined #define, but thats not because of the redefine itself.

I like to redefine NULL on projects i know are going crossplatform, then i know what its going to be, theres only a few rare systems where NULL isn't 0, but i've seen enough uses of (void*) 0 to do it, plus it doesn't hurt anything.

using null as an arrayname though is asking for trouble

dnd · 12-12-2003, 06:22 PM

arghhhh i forgot how much i hated c++ .... i'm so glad i learnt java first....wrong way round i know...but its just so much easier! pointers may be helpful, but understanding them takes a long time!

charliex · 12-12-2003, 06:32 PM

yep a lot of people probably can get by without pointers, but the things i miss the most in java are pointers, enums and #defines (though i do use #defines and run it through a preprocessor )

Oh and a stable development environment, and speed .. ok'll i'll stop

oberon · 12-13-2003, 11:10 AM

Pointers are pretty important to figure out. Can't be a good programmer without understanding them, in my opinion.

Pragma · 12-13-2003, 02:49 PM

If you think C/C++ pointers are bad, go learn Brainfuck. You'll petition to have the word "pointer" removed from the English language.

oberon · 12-14-2003, 05:57 AM

LOL, yeah, brainfuck is a great language for that purpose.

Next, try to figure out assembly (any architecture, preferably x86 for maximum pain) without understanding pointers.

12-11-2003, 06:03 AM	#2 (permalink)
Prince /nɑndəsˈkrɪpt/ Location: LV-426	Well, vB removes some small parts of the code apparently in its battle against html tags, but I hope that is understandable anyway. __________________ Who is John Galt?

12-11-2003, 08:11 AM	#4 (permalink)
Pragma I am Winter Born Location: Alexandria, VA	Well, you can't do "delete null;", as it's not dynamic memory. Other than that, why are you using an ifstream pointer instead of just an ifstream object? Furthermore, C++ really doesn't like it when you redefine constants for it - such as NULL. __________________ Eat antimatter, Posleen-boy!

12-11-2003, 08:27 AM	#5 (permalink)
Prince /nɑndəsˈkrɪpt/ Location: LV-426	You're a genius. Thanks! __________________ Who is John Galt?

12-12-2003, 06:00 AM	#8 (permalink)
Pragma I am Winter Born Location: Alexandria, VA	True, you can redefine constants, but most compilers will give you warnings, if not errors, if you don't #undef before you #define. Either way, I've seen very few cases (and this not being one of them) were actually redefining NULL is warranted. __________________ Eat antimatter, Posleen-boy!

12-12-2003, 06:22 PM	#10 (permalink)
dnd Psycho Location: London...no longer a student	arghhhh i forgot how much i hated c++ .... i'm so glad i learnt java first....wrong way round i know...but its just so much easier! pointers may be helpful, but understanding them takes a long time! __________________ "Never underestimate a dumb question"-- Brandon Boyd

12-11-2003, 12:12 PM	#6 (permalink)
cheerios Banned Location: 'bout 2 feet from my iMac	for future reference code tags (use em just like quote ones) are great

12-11-2003, 08:32 PM	#7 (permalink)
charliex Junkie Location: North Hollywood	its ok to redefine #define constants, you can even use #undef if you want too first. NULL is compiler specific, so sometimes you want to override it because the compiler maker goofed it up , say using (void*)0 instead of 0 or 0L

12-12-2003, 05:57 PM	#9 (permalink)
charliex Junkie Location: North Hollywood	You should never get an error redefining a #define, a typedef yes, if you do the compilers broken. some compilers will generate an error using #undef on something that was never #define'd so you should always guard it. Unfortunately theres no easy way of telling the difference between a typedef and a #define. You might get an error on the use of the redefined #define, but thats not because of the redefine itself. I like to redefine NULL on projects i know are going crossplatform, then i know what its going to be, theres only a few rare systems where NULL isn't 0, but i've seen enough uses of (void*) 0 to do it, plus it doesn't hurt anything. using null as an arrayname though is asking for trouble

12-12-2003, 06:32 PM	#11 (permalink)
charliex Junkie Location: North Hollywood	yep a lot of people probably can get by without pointers, but the things i miss the most in java are pointers, enums and #defines (though i do use #defines and run it through a preprocessor ) Oh and a stable development environment, and speed .. ok'll i'll stop

12-13-2003, 11:10 AM	#12 (permalink)
oberon Quadrature Amplitude Modulator Location: Denver	Pointers are pretty important to figure out. Can't be a good programmer without understanding them, in my opinion. __________________ "There are finer fish in the sea than have ever been caught." -- Irish proverb

12-13-2003, 02:49 PM	#13 (permalink)
Pragma I am Winter Born Location: Alexandria, VA	If you think C/C++ pointers are bad, go learn Brainfuck. You'll petition to have the word "pointer" removed from the English language. __________________ Eat antimatter, Posleen-boy!

12-14-2003, 05:57 AM	#14 (permalink)
oberon Quadrature Amplitude Modulator Location: Denver	LOL, yeah, brainfuck is a great language for that purpose. Next, try to figure out assembly (any architecture, preferably x86 for maximum pain) without understanding pointers. __________________ "There are finer fish in the sea than have ever been caught." -- Irish proverb