View Single Post
Old 04-30-2005, 03:13 PM   #19 (permalink)
Silvy
paranoid
 
Silvy's Avatar
 
Location: The Netherlands
Quote:
Originally Posted by arch13
Nope
I see two problems going on here, and I'm trying to see how we can fix them.
The first is actually straight foreward, but I almost didn't spot it.
We can't have $base= "brewery_"; like I suggested. It needs to be just "brewery" since the base statment is also used for finding the paths.
Which paths?
I see the folllowing path info needed at some point:
- the path to the images (in brewery.php), this is set via the constant. $base, has no influence on that
- the path to brewery.php (in index.php), this is built out of $id= $_REQUEST['id'], $base has got nothing to do with it.
- the actual filename of the image. $base is used here, but not for the path, only for the image name. IMAGE_FS_PATH and IMAGE_WWW_PATH are used to get the directory structure.

So we build the full image path/name out of the following compontents:
constant: IMAGE_FS_PATH (= '/imgs/')
variable: $base (='brewery_')
variable: $id (='1');
string: '.jpg'
concatenating to: '/imgs/brewery_1.jpg' right?

Quote:
Originally Posted by arch13
Throwing in the underscore to makes the images work but makes the file paths not work.
Perhaps
file_exists(IMAGE_FS_PATH.$base._$id.'jpg';
But that screws up the code (I tried it).
Not a bad idea, but: the underscore is a seperate string. so put quotes(') around it, and concatenate it with dots (.), like so:
file_exists(IMAGE_FS_PATH.$base.'_'.$id.'jpg';
(but this is not necessary now, as $base can just contain the underscore)

Quote:
Originally Posted by arch13
Honestly, It's simplest for me to just change the image names to brewery1.jpg, since that should make the code work. I'll try it right now before continuing this post...
Nope
I think this may have to do with the path setting.
Try setting IMAGE_FS_PATH to the real filesystem path. (i.e. /var/www/etc)
this is needed on my setup, but it could very well different on yours.

Quote:
Originally Posted by arch13
I set
PHP Code:
<?php
define 
('IMAGE_FS_PATH''/img/');  //this should be the full filesystem path to your images
define ('IMAGE_WWW_PATH''img/');  //this should be the path relative to the URL.  (so it will expand to http://www.arch13.com/img/ etc)
?>
Before the body html in index.php right under my javascripts, is that an okay position?
As long as it is before you include files (brewery.php needs those 2 definitions).
I usually put them at the very top of my php files, as a sort of initialization. But so long as they're defined before they're used, it's fine
Quote:
Originally Posted by arch13
The system path is correct, as the php install is supposed to see my / as the root and works in all instances I've used it as such. It's not parse erroring, brewery_test is, so I assume it's working fine.
parse errors only mean that the syntax is wrong, it does not say anything about the values (in this case system paths) of variables.
I'm not sure what you mean by 'supposed to see my / as the root'.
Try setting IMAGE_FS_PATH to the FULL system path '/var/www/htdocs/whatever/' and set IMAGE_WWW_PATH to 'img/' (in the define statements in index.php)
(include the trailing slash on both constants)

Post the contents of index.php and brewery.php again, and any parse errors you got but couldn't fix. I think we're down to a few typos here or there.
(mainly in the paths or image names)

Btw: I see a unexpected T_CONSTANT_ENCAPSED_STRING error on your test page, check the line (53) for unmatched quotes (' or ") or a missing semi-colon( ; ) the semi-colon could also be missing on line 52.

Another note: the code above should be outputting HTML looking for images in http://www.arch13.com/imgs/brewery_1.jpg (and so on).
But looking for that URL gives me 404 errors. If the above URL should be correct, you might need to fix that first. If this URL to the image is not supposed to be correct, the code above needs fixing
__________________
"Do not kill. Do not rape. Do not steal. These are principles which every man of every faith can embrace. "
- Murphy MacManus (Boondock Saints)
Silvy is offline  
 

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360