Not being disrespectful, but this is a case where the last part really is the most important so I removed most of the quote to get to the good stuff
:
Quote:
|
Originally Posted by arch13
So my next question is how do we account for brewery.php not being in the same folder as the images?
I assume we need to change the if(file_exists($base.$id.".jpg")) statment to reflect that it needs to check www/imgs/brewery for the files existance instead. Would it be if(file_exists(imgs/$base.$id.".jpg")) then?
|
Very close! You see, the file_exists function looks for files
relative to it's own location. Since brewery.php is in www/brewery/ the above file_exists will look for www/brewery/imgs/brewery_1.jpg
What we need is it to look for 1 directory higher than itself.
This can be done in one of 3 ways:
By using the full path of the file (so it looks for an absolute path, instead of a relative path.) (file_exists("/var/www/localhost/http/whatever/www/img/brewery_1.jpg")
By using a relative path, but to look one dir higher (file_exists("../imgs/brewery_1.jpg")
By using a global directive to point to the file locations.
This one should be relatively easy to grasp so we're going to do this the most elegant way (via the global constant).
Since all images are always located in www/imgs let's have index.php set the image_path constant:
(put this in the top-section of index.php, makes it easier to find later)
PHP Code:
<?php
define ('IMAGE_FS_PATH', '/var/www/img/'); //this should be the full filesystem path to your images
define ('IMAGE_WWW_PATH', 'img/'); //this should be the path relative to the URL. (so it will expand to http://www.arch13.com/img/ etc)
?>
Then, change the $base statement, the first file_exists statement, and the echo statement in brewery.php to use the new paths:
PHP Code:
$base = "brewery_"; //like you said
file_exists(IMAGE_FS_PATH.$base.$id.'jpg'; //this expands into '/var/www/img/brewery_1.jpg
echo "<img src='".IMAGE_WWW_PATH.$base.$id".jpg'>"; this expands into imgs/brewery_1.jpg, which will allow the browser to find it relative to "http://www.arch13.com"
And leave the rest of the code as-is.
Does it work now?
Now, on to the rest of your post:
Quote:
|
Originally Posted by arch13
It doesn't work becuase the php file and images are in different folders.
|
Right, the above code should have fixed that. (in one of three ways)
In response to my question:
Quote:
|
Originally Posted by Silvy
This gets interesting. Do you want p_gallery to call $_REQUEST['id2'] directly? Or do you want index.php to set up a special variable for it?
|
Your answer:
Quote:
|
Originally Posted by arch13
To see this in action, go see the portfolio page via the link on the navbar of my site. It's just a daisy chain of includes. Index.php--->p_gallery.php--->gal.php
what do you mean by special variable?
Is there another way than just using id and id2 like I'm doing? It's clean and simply currently, but I'm always for less complication.
|
Right, I understand how p_gallery.php works. It calls $_REQUEST['id2'] to find out what it must do. The special variable I was talking about, was a part of
advanced variable scope 101 
Let's say for example that you want to re-use p_gallery for something else. Something where you don't know what's in the URL, so you expect another variable to be set.
index.php could set up a variable $included_file_parameters, which could then be read by whichever file is included (in our current code index.php would execute $included_file_paramters=$_REQUEST['id2']). This is neater (in my opinion) and more maintainable. But, for now, we should leave it as-is.
Quote:
|
Originally Posted by arch13
I want -brewery.php- to be in www/brewery with the images in www/imgs/brewery (I like having all images in a single folder for clarity)
images have always been there throughout our posts. This is part of my "don't show the path question".
|
Agreed.
Quote:
|
Originally Posted by arch13
So I guess that what needs to happen is:
index.php does a file_exists ('brewery.php')
index.php then does a file exists ('brewery/brewery.php')
(Then the splash)
Brewery.php looks in a www/imgs/same name as php file for it's images
(and then the splash)
|
Woa partner, easy there
Yes, it can look for the "same name as php file" files, but for now we're hardcoding it in $base. That means you need to change it if you copy brewery.php to another some_other_building.php small inconvenience for now. But it is the reason we're using a dedicated $base variable, so if you copy the code, you just need to change $base="brewery_" to $base="some-other-building_" to make all of it work
I think we should have a working page now.