Quote:
|
Originally Posted by Silvy
(I've tried to use as much of your code as possible to help you understand what's going on. I also added comments, but if it's not completely clear, please do ask! Check this code against yours above to see the differences, I couldn't find a good way to display the differences...)
Code:
/* Set up external variables */
$id = $_REQUEST['id'];
$id2 = $_REQUEST['id2'];
/* This is the place for the "optional" sanitizing of the variables you got from the URL */
/* Set up constants */
// Note, we're not using constants much, but it helps getting used to them
define('IMAGE_PATH', 'img/'); // From now on we can use IMAGE_PATH, and it will substitute the string 'img/' for it. If you ever change the images directory, then changing this constant is enough for your entire code.
/* setup complicated variables */
$filename=$id.'_'.$id2.'.jpg' // Since we defined $id / $id2 to be the URL variables before, we can use them. Saves typing, and makes it easier to read.
$image_location=IMAGE_PATH.$filename // Becomes 'img/brewery_1.jpg' in our example
/* program flow */
if(file_exists($image_location)) { // We already "built" the location variable, no need to do it again ;)
echo "<img src='$image_location'>"; // Same here...
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='brewerysplash.jpg'>";
}
Notes: - When naming variables that represent values you got from the URL, be careful. Your code was confusing in that you set $id to be URL value id2
- In that respect, to help read your code, it might help to name the variables "gallery" and "img_id" just so it is never unclear of which is which. Of course, it is not necessary, and for the sake of continuing this thread it might be better to leave it as-is for now.
- Seperating the creation of the image path, instead of just using file_exists('img/'.$id.'.jpg) allows for easy manipulation in the beginning of the code while ensuring that any changes propagate nicely. Otherwise a decision to use, say, GIFs would require you to look up all references to .jpg and change them. In the code above only one line of code needs to be changed.
- On that note, it's probably more elegant to have another variable "alternative_location" (or something like that) to define what file should be included if the image is not found (instead of "building" that in your program flow itself.
- Once you get this down, and made it work (Code never works out-of-the-box
 )Try looking into sanitizing the input variables ($id / $id2) to make sure that no dots and slashes are in them. Better safe than sorry, and it's good practice.
|
Okay, I tried your code and it parse errors badly. I see why though, so that's good that I'm understanding that much.
Here's how it's working (This will also address your first list point):
Main page index.php contains the following:
PHP Code:
$id = $_REQUEST['id'];
if(file_exists($id.".jpg")) {
echo "<img src='$id.jpg'>";
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='Brewerysplash.jpg'>";
}
The included page then has:
PHP Code:
$id = $_REQUEST['id2'];
if(file_exists($id.".jpg")) {
echo "<img src='$id.jpg'>";
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='brewerysplash.jpg'>";
}
So your suggestion does not work becuase there are two php scripts on different pages at play here.
index.php has the script with $id = $_REQUEST['id'] in it, while whatever page is included has the php code for $id = $_REQUEST['id2'].
That way, if a page included through id variable does not make use of id2, there is no id2 script in the included page. An example is my "main/about" page at
www.arch13.com/index.php?id=main where the first script is in the template page that has all the tables (index.php), and the main.php page then has a script for id2 to call the left hand image.
So I guess what I'm searching for is a way to keep the index.php script intact, and sinply pass the id variable onto the second script so it can use it as above for id2?
Or would using your suggested page on the index.php page, and simply creating an anchor for id2 in any included page be more effeciant?
Am I making any sense?
hmmm. To put it another way, do I scrap the two scripts, on on each page with one for id and one for id2, and replace it with a single script on index.php, and create say echo ($id2.".jpg") on the brewery page where I want the image to be, or is it better to work with two php scripts, one on the index page addressing id, and one on whatever page id calls addressing id2?
With that second option, could the needed information be passed between the two seperate scipts addressing id's 1&2 so that your suggested code could work if used in the brewery page?
/Arch13's brain explodes