View Single Post
Old 04-15-2004, 10:11 AM   #1 (permalink)
Stompy
Banned from being Banned
 
Location: Donkey
[SQL] Is this query optimized?

I'll try to keep this simple and easy to follow

Let's say I have a system where I run reports on Sales Agents. I return the data once a day and tally up the amount of meetings they attended along with a transaction (sales) summary.

The data is to be presented on ONE line.

To show this example, I have 3 tables: Agents, Meetings, and Transactions.

Agents contains:

Code:
AgentID     Name                                               
----------- -------------------------------------------------- 
1           Bob
2           Bill
Meetings contains:

Code:
MeetingID   AgentID     MeetingDate                                            
----------- ----------- ------------------------------------------------------ 
1           1           2004-04-15 11:00:00.000
2           1           2004-04-15 12:00:00.000
3           1           2004-04-15 13:00:00.000
4           2           2004-04-15 09:00:00.000
Transactions contains:

Code:
TransID     AgentID     TransTypeID Amount      
----------- ----------- ----------- ----------- 
1           1           1           5
2           1           2           10
3           1           3           15
4           1           1           10
5           2           3           50

I need the results returned ONE agent per line, total meetings, and each transaction type (with amount sum) displayed as shown in the following:

Code:
Name                                               Meetings    Type1       Sum1        Type2       Sum2        Type3       Sum3        
-------------------------------------------------- ----------- ----------- ----------- ----------- ----------- ----------- ----------- 
Bill                                               1           0           0           0           0           1           50
Bob                                                3           2           15          1           10          1           15
The query I'm using for this is:

Code:
SELECT
	A.Name, 
	COUNT(DISTINCT dbo.Meetings.MeetingID) AS Meetings, 
	Type1 = (SELECT COUNT(*) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 1),
	Sum1 = (SELECT ISNULL(SUM(Amount), 0) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 1),
	Type2 = (SELECT COUNT(*) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 2),
	Sum2 = (SELECT ISNULL(SUM(Amount), 0) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 2),
	Type3 = (SELECT COUNT(*) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 3),
	Sum3 = (SELECT ISNULL(SUM(Amount), 0) FROM Transactions T WHERE AgentID = A.AgentID AND T.TransTypeID = 3)
FROM         
	dbo.Agents A LEFT OUTER JOIN dbo.Meetings ON A.AgentID = dbo.Meetings.AgentID
GROUP BY 
	A.Name,
	A.AgentID
ORDER BY 
	A.Name
The question I have is... is there a more efficient way to get the results I want? It seems highly inefficient to be querying against the same table six times for every record returned.

In the real world situation I'm working with, there are 6 different types with corresponding amounts that need to be displayed, so that'd be 12 queries per row. There could be tens of thousands of agents with hundreds of thousands of transaction records, so doing something like this would seem overkill on the server.

I COULD query it like so:

Code:
SELECT
	dbo.Agents.Name, 
	COUNT(DISTINCT dbo.Meetings.MeetingID) AS Meetings, 
	dbo.Transactions.TransTypeID, 
	SUM(DISTINCT dbo.Transactions.Amount) AS TransAmount
FROM         
	dbo.Agents LEFT OUTER JOIN dbo.Transactions ON dbo.Agents.AgentID = dbo.Transactions.AgentID 
		LEFT OUTER JOIN dbo.Meetings ON dbo.Agents.AgentID = dbo.Meetings.AgentID
GROUP BY 
	dbo.Agents.Name, 
	dbo.Transactions.TransTypeID
ORDER BY 
	dbo.Agents.Name
which will return the following results:

Code:
Name                                               Meetings    TransTypeID TransAmount 
-------------------------------------------------- ----------- ----------- ----------- 
Bill                                               1           3           50
Bob                                                3           1           15
Bob                                                3           2           10
Bob                                                3           3           15
...which would require me to loop through EACH record, check the TransType, then put it in it's proper position in the table in HTML, but this is done in asp.net and it's a headache to add items "manually" like that.

[edit]
Not to mention it would throw off paging. If the above dataset was limited to 2 records per page, instead of showing one for Bill and one for Bob, you'd end up with one for Bill, and 1/3 of the data for Bob.

However, if that's my only option, then I guess I have no choice

Just wanted other opinions on what I should do, or the most recommended route to tackle this. Thanks

Last edited by Stompy; 04-15-2004 at 11:48 AM..
Stompy is offline  
 

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360