Warning, read the entire post, answer the last part first, it'll probably be the most relevant.
Quote:
|
Originally Posted by arch13
Index.php is the template page. It is what is seen at www.arch13.com . It's the backround, navigation, etc. It's all built with html and css, it's just a php file to allow it to be parsed for the include script that includes the footer copyright and the main window content. It's the frame that displays in other words. You are right that it will do one of the three mentioned based on the url variables and if id=blah is a php or jpg file.
I like that functionality, and it took a while to figure it out with lots of help. The else is just to put something (brewerysplash.jpg) up should they try to request something that does not exist. |
Understood. And I agree.
Quote:
|
Originally Posted by arch13
$id.php is whatever plaintext file I'm displaying in the templates content area. if you go to my front page, where brewerysplash.jpg is, that is the "content area". The point has always been seperating content from display. That way, many different types of content can be placed in that box based on what I want the viewer to see. Conversly, I can change the template, and not have to edit or change any of the included files.
|
Right. So far we're on the same track. 3 files:
1 content ($id.php)
1 mostly structure (index.php)
1 layout, color etc (css)
Quote:
|
Originally Posted by arch13
There are areas where we get complicated. In my portfolio for example. Index.php calls p_gallery into the content area using $id, and then p_gallery call's portfolio_gal.php through $id2 to build the thumbnail table. In this case, $id and $id2 have othing to with one another besides doing similar actions (calling in another file via include)
|
This gets interesting. Do you want p_gallery to call $_REQUEST['id2'] directly? Or do you want index.php to set up a special variable for it?
Quote:
|
Originally Posted by arch13
The feeling I got was this. Right now index.php has the first $id php script in it's content area box. I need that to always work, regardless of what the included page has in it's coding. $id is how I choose what file to display there. $id2 is what I use when the included page also needs to include something.
|
I'm assuming you've got some way to generate the correct URL's (with the id2 and stuff).
Quote:
|
Originally Posted by arch13
I'm not trying to disguise on as the other.
I'm currently calling $_REQUEST['id2'] from the included file I caled using $id if I understand your first list point 
Can I use the $id variable from the index page in the included pages php script? That's what I was trying to ask in less well phrased questioning. 
So, On to the actual markup of index.php and brewery.php as maybe that will help you understand what I'm asking instead of me babbling  |
Actually 'disquise' is the wrong word. I meant wether you wanted the value of id2 put into variable $id for the included file.
Actually for that first list point I meant that $_REQUEST['id2'] should
not be put into a variable $id if there is no specific reason. Because when you read through your code later, you might mistake $id coming from $_REQUEST['id']. I usually try to name my variables logically to make the code easier to understand.
Ofcourse if a script depends on the existance of $id. And the value for it is located in $_REQUEST['id2'], by all means do that.
On to the next post:
Quote:
|
Originally Posted by arch13
So here is my index.php:
My class="contentbox" is my content display area. As you see, the php that calls $id is there so that depending on the url, it places the included file called in that box.
|
Got it. Looks good.
Quote:
|
Originally Posted by arch13
Now brewery.php:
|
Say index.php is located in www/
Where is brewery.php located? (and if you had a choice, where do you want it to be after we're done?)
- in www/
- in www/brewery
- in www/imgs/brewery
The reason I'm asking is that it looks like all files are currently in the same directory. (judging by a quick glance through the code).
Then again, you mentioned paths in your URLs before, so this is indeed a problem we need to tackle. Apparently your index.php is in (say) www/
your images are in www/brewery/ (ex. www/brewery/brewery1.jpg)
Since we're hiding the path now, we need to decide where you want the middle-man (brewery.php, which essentially is the second file in the include-chain).
I'd suggest:
index.php does a file_exists('brewery.jpg') (so local to the index.php)
index.php then does a file_exists('brewery/brewery.php') (so in a sub-dir from index.php)
(and then the splash)
brewery.php looks in it's local directory for the images.
brewery.php looks in a subdir for the include
(and then the splash)
etc.
Quote:
|
Originally Posted by arch13
So here is the goal in a nutshell: Clean up the php coding to be more efficiant, and so that $id2=12345 instead of the name. Your previously suggested, parse failed script is hitting the nail on the head of intent there. Of course, that is only for this include page that I want it to work that way. In the case of www.arch13.com/index.php?id=p_gallery, I still need $id2 to work as it does currently. (when it doesn't, you'll notice that clicking that url defaults to a picture of a boiler on the left instead of a thumbnail table since the url didn't set an $id2)
The solution I'm searching for is something to use on all the building gallery pages. Brewery.php, stockhouse.php, etc.
So the url www.arch13.com/index.php?id=brewery will display the brewery.php file in the content box of the index.
Becuase I still need the code to work in way similar to currently on some pages, while the way we're discussing on others, I thought keeping the $id and $id2 scripts seperate was a good idea. But I know a lot less about clean code than you do. |
-blush- thanks.
I think you'll find the above set up of file locations to be a good step towards your goal.
Note, about the code, I wrote the script to replace the code in index.php (hence some confusion there. This was my fault, as I thought it would reference the images directly. )
Given the mix-up, all your comments are correct.
Quote:
|
Originally Posted by arch13
I want to create a new set of pages, one for each building I document. On these pages, the solution I want is what we are discssuing.
So to comment on your script as suggested:
|
Right, and I suggest placing the PHP file of each building in a seperate directory with it's images. Cleans it up quite nicely. Plus if you ever (re)move an image set, the PHP file goes with it, all neat.
Quote:
|
Originally Posted by arch13
Am I loosing you at this point?
I really hope not 
Can your suggested script be made to work while leaving the php script in index.php the same and just messing with the php script on the included page, or is this going to take a whole new appraoch? |
Actually, you just got me back
With the above set up we can leave most of the files the way they are.
To be absolutely compatible with the current situation (but migrate to the file setup I mentioned earlier) change this in index.php:
Code:
$id = $_REQUEST['id'];
if(file_exists($id.".jpg")) {
echo "<img src='$id.jpg'>";
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='Brewerysplash.jpg'>";
}
In to:
Code:
$id = $_REQUEST['id'];
if(file_exists($id.".jpg")) {
echo "<img src='$id.jpg'>";
} elseif( file_exists( $id."/".$id.".php" ) {
include( $id."/".$id.".php"
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='Brewerysplash.jpg'>";
}
Essentially, I just added elseif( file_exists( $id."/".$id.".php" )
This checks wether a subdirectory exists with a php file.
Now all images are in www/brewery right?
put the brewery.php in there as well.
If the images in www/brewery are called brewery1.jpg and so on change
Code:
$id = $_REQUEST['id2'];
if(file_exists($id.".jpg")) {
echo "<img src='$id.jpg'>";
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='brewerysplash.jpg'>";
}
In to:
Code:
$base = 'brewery'; //only for images if they are called brewery1.jpg etc.
$id = $_REQUEST['id2'];
if(file_exists($base.$id.".jpg")) {
echo "<img src='$base.$id.jpg'>";
} elseif(file_exists($id.".php")) {
include($id.".php");
} else {
echo "<img src='brewerysplash.jpg'>";
}
I added a "$base = " statement, and added $base to the 2 image searching and loading lines.
(if the images in www/brewery are called 1.jpg, 2.jpg etc you can leave the code as-is).
It should then work.
(forgetting all those things about coding practices, constants and other stuff, let's get it to work first
)
Then we'll clean up the code.
This way, if I'm correct, all should work the same as it is now but for brewery. Brewery can now use shorter URLs
http://www.arch13.com/index.php?id=brewery&id2=1 should load up the page through index.php, which looks for brewery/brewery.php and includes it. Brewery.php then looks for brewery1.jpg, finds it and echo's the corresponding HTML.
Are we getting somewhere?
Btw, if there is a maximum post size on this forum, we should be reaching it pretty soon