Tilted Forum Project Discussion Community  

Go Back   Tilted Forum Project Discussion Community > Interests > Tilted Technology


 
 
LinkBack Thread Tools
Old 12-06-2004, 05:13 PM   #1 (permalink)
Upright
 
[C++] Multidimensional array problem

I'm using fstream in Visual C++ to read a maze from a text file into a multidimensional array and output it to another text file. I keep running into a problem somewhere along the line because the output is missing lines of the maze and gives me a bunch of weird characters.

This is my code for reading in and outputting:
void read(int &x, int &y, char path[100][100])
{
string filein, fileout;
int l;

cout << "Enter filename: ";
cin >> filein;

l=0;
while(filein[l] != '.')
{
fileout += filein[l];
l++;
}
fileout += "_path.txt";
mazein.open(filein.c_str());
mazeout.open(fileout.c_str());

mazein >> x >> y;

for(int a = 0; a <= y; a++)
{
for(int b = 0; b < x; b++)
{
mazein.get(path[b][a]);
}
mazein.get();
}
}

void print(int x, int y, char path[100][100])
{
for(int a = 0; a <= y; a++)
{
for(int b = 0; b < x+1; b++)
{
if(path[b][a] == 'X')
{
path[b][a] = ' ';
}
mazeout << path[b][a];
}
}
}

Any thoughts?

Last edited by Rambo; 12-06-2004 at 05:24 PM..
Rambo is offline  
Old 12-06-2004, 06:22 PM   #2 (permalink)
a-j
Tilted
 
Just off the top of my head, I would guess that you're not reading the input file correctly, and end up reading CR/LF characters. You start by using the stream extraction operator >> to read x and y (which I assume is the dimension of the array). Couldn't you do the same thing to read the maze data. If part of the data consists of spaces, it may be a little trickier, but probably possible if you take a look at the ifstream docs. I suspect you are not getting past the end of lines (which are actually two bytes on windows). Also check for unnecessary whitespace.

Also
when you combine for styles it becomes hard to read please stick to one style or the other. I prefer this one, and I'm sure it's the more common:
Code:
for (int i = 0; i < x; i++)
rather than this one
Code:
for (int i = 0; i <= x+1; i++)
Edit:
Look at your loops, there is inconsistency in the number of times you are looping, and I think only the 2nd loop is correct (loops x times).

Code:
for(int a = 0; a <= y; a++) {    // loops y+1 times
    for(int b = 0; b < x; b++) {    // loops x times
...
for(int a = 0; a <= y; a++) {    // loops y+1 times
    for(int b = 0; b < x+1; b++) {    // loops x+1 times

Last edited by a-j; 12-06-2004 at 08:04 PM..
a-j is offline  
 

Tags
array, multidimensional, problem

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT -8. The time now is 06:56 AM.

Tilted Forum Project

Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Search Engine Optimization by vBSEO 3.6.0 PL2
© 2002-2012 Tilted Forum Project

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360